-
Notifications
You must be signed in to change notification settings - Fork 374
ci(repo): Version packages #6552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughDeleted two changeset metadata files and added patch release entries and package version bumps across many packages. packages/nextjs received a 6.31.2 changelog entry mentioning: keyless drift logic adjustments (now considers client components and only development apps), switching internal fs imports to nodeFsOrThrow, and an update to createClerkClient/ClerkOptions to accept telemetry.samplingRate. Most other changes are changelog additions and patch version increments with dependency bumps; no other public API signatures were modified in this diff. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/nextjs/CHANGELOG.md (2)
3-8
: Tighten wording and split the combined bullet for clarity
- “apps on development” should be “apps in development”.
- Split the drift fix and API change into separate bullets to improve readability.
Apply this diff:
## 6.31.2 ### Patch Changes -- Fix keyless drift logic to support client components and ensure only apps on development are included. Change createClerkClient to accept an argument for samplingRate in telemetry options and update the ClerkOptions type. ([#6539](https://github.com/clerk/javascript/pull/6539)) by [@heatlikeheatwave](https://github.com/heatlikeheatwave) +- Fix keyless drift logic to support client components and ensure only apps in development are included. ([#6539](https://github.com/clerk/javascript/pull/6539)) by [@heatlikeheatwave](https://github.com/heatlikeheatwave) +- Add support for telemetry.samplingRate in createClerkClient and update the ClerkOptions type.
3-8
: Ensure tests cover the new telemetry option pathNo tests were added in this release PR. Please confirm that tests for telemetry.samplingRate handling and ClerkOptions type changes landed with the implementing PR, or add coverage if missing.
If helpful, I can draft unit/integration test cases targeting the new telemetry option flow. Do you want me to open a follow-up PR?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.changeset/fine-weeks-give.md
(0 hunks)packages/nextjs/CHANGELOG.md
(1 hunks)packages/nextjs/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/fine-weeks-give.md
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/nextjs/CHANGELOG.md
packages/nextjs/package.json
packages/**/CHANGELOG.md
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Maintain detailed changelogs
Files:
packages/nextjs/CHANGELOG.md
**/*
⚙️ CodeRabbit Configuration File
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
packages/nextjs/CHANGELOG.md
packages/nextjs/package.json
packages/*/package.json
📄 CodeRabbit Inference Engine (.cursor/rules/global.mdc)
All publishable packages should be placed under the packages/ directory
packages/*/package.json
: All publishable packages must be located in the 'packages/' directory.
All packages must be published under the @clerk namespace on npm.
Semantic versioning must be used across all packages.
Files:
packages/nextjs/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: semgrep/ci
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
packages/nextjs/package.json (2)
3-3
: Patch version bump looks correct and compliant
- Package remains under the @clerk namespace and within packages/, satisfying repo rules.
- A patch bump is acceptable for an additive, optional API shape (telemetry.samplingRate) and a bug fix release.
No further action needed.
1-104
: Telemetry.samplingRate and ClerkOptions changes verified — no action requiredConfirmed: the new telemetry.samplingRate is defined in the shared telemetry types and is accepted/passed through createClerkClient; nextjs helper forwards it and keyless telemetry usage passes samplingRate explicitly.
Files checked:
- packages/shared/src/telemetry/types.ts — TelemetryCollectorOptions includes samplingRate?: number
- packages/backend/src/index.ts — ClerkOptions includes telemetry?: Pick<TelemetryCollectorOptions, 'disabled' | 'debug' | 'samplingRate'> and createClerkClient spreads opts.telemetry into TelemetryCollector (default samplingRate: 0.1)
- packages/nextjs/src/server/createClerkClient.ts — createClerkClientWithOptions is typed as typeof createClerkClient and forwards telemetry via merged options
- packages/nextjs/src/server/keyless-telemetry.ts — code calls createClerkClientWithOptions({ ..., telemetry: { samplingRate: 1 } }) and records telemetry
packages/nextjs/CHANGELOG.md (1)
3-8
: Consider whether the API addition warrants a minor bump per semverAdding an optional public option is non-breaking and commonly shipped as a patch in this repo, but semver purists may expect “new functionality” to be a minor. If this was intentional, ignore; otherwise consider bumping minor.
755c09e
to
8626add
Compare
8626add
to
35983d7
Compare
35983d7
to
78522f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/expo-passkeys/package.json (1)
33-33
: Nit: Remove double space in script argument listMinor cleanliness nit in the publish:local script; there’s a double space before --sig.
- "publish:local": "pnpm yalc push --replace --sig" + "publish:local": "pnpm yalc push --replace --sig"packages/expo/CHANGELOG.md (1)
5-12
: Optional: add a quick note about the transitive fix picked up via dependency bumps.This mirrors context in the PR summary (setActive stale org data handling) and helps Expo users understand there's no direct code change in this package.
Apply this diff to add one bullet under "Patch Changes":
### Patch Changes - Updated dependencies [[`413468c`](https://github.com/clerk/javascript/commit/413468c9b9c8fb7576f8e4cbdccff98784e33fef)]: - @clerk/[email protected] - @clerk/[email protected] - @clerk/[email protected] - @clerk/[email protected] + - Note: No direct Expo changes; picks up @clerk/clerk-js 5.85.1 fix for setActive with stale organization data (see PR #6550).packages/express/CHANGELOG.md (1)
3-11
: Consider adding/ensuring a minimal smoke/integration check for Express against updated backend/types/sharedNo tests changed in this release PR. Given the dependency bumps, a lightweight integration test (or CI job step) that spins up a minimal Express route with the updated @clerk/backend/@clerk/types/@clerk/shared would help catch unexpected drifts.
If useful, I can draft a minimal Express smoke test scaffold wired to the current monorepo test runner.
packages/react-router/CHANGELOG.md (1)
5-11
: Optional: add a clarifying note that this release only updates dependenciesAdding an explicit line helps readers scanning the changelog quickly.
### Patch Changes -- Updated dependencies [[`413468c`](https://github.com/clerk/javascript/commit/413468c9b9c8fb7576f8e4cbdccff98784e33fef)]: +- No code changes; dependency updates only. +- Updated dependencies [[`413468c`](https://github.com/clerk/javascript/commit/413468c9b9c8fb7576f8e4cbdccff98784e33fef)]: - @clerk/[email protected] - @clerk/[email protected] - @clerk/[email protected] - @clerk/[email protected]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (47)
.changeset/fine-weeks-give.md
(0 hunks).changeset/itchy-queens-cough.md
(0 hunks).changeset/shaky-cities-search.md
(0 hunks)packages/agent-toolkit/CHANGELOG.md
(1 hunks)packages/agent-toolkit/package.json
(1 hunks)packages/astro/CHANGELOG.md
(1 hunks)packages/astro/package.json
(1 hunks)packages/backend/CHANGELOG.md
(1 hunks)packages/backend/package.json
(1 hunks)packages/chrome-extension/CHANGELOG.md
(1 hunks)packages/chrome-extension/package.json
(1 hunks)packages/clerk-js/CHANGELOG.md
(1 hunks)packages/clerk-js/package.json
(1 hunks)packages/elements/CHANGELOG.md
(1 hunks)packages/elements/package.json
(1 hunks)packages/expo-passkeys/CHANGELOG.md
(1 hunks)packages/expo-passkeys/package.json
(1 hunks)packages/expo/CHANGELOG.md
(1 hunks)packages/expo/package.json
(1 hunks)packages/express/CHANGELOG.md
(1 hunks)packages/express/package.json
(1 hunks)packages/fastify/CHANGELOG.md
(1 hunks)packages/fastify/package.json
(1 hunks)packages/localizations/CHANGELOG.md
(1 hunks)packages/localizations/package.json
(1 hunks)packages/nextjs/CHANGELOG.md
(1 hunks)packages/nextjs/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(1 hunks)packages/nuxt/package.json
(1 hunks)packages/react-router/CHANGELOG.md
(1 hunks)packages/react-router/package.json
(1 hunks)packages/react/CHANGELOG.md
(1 hunks)packages/react/package.json
(1 hunks)packages/remix/CHANGELOG.md
(1 hunks)packages/remix/package.json
(1 hunks)packages/shared/CHANGELOG.md
(1 hunks)packages/shared/package.json
(1 hunks)packages/tanstack-react-start/CHANGELOG.md
(1 hunks)packages/tanstack-react-start/package.json
(1 hunks)packages/testing/CHANGELOG.md
(1 hunks)packages/testing/package.json
(1 hunks)packages/themes/CHANGELOG.md
(1 hunks)packages/themes/package.json
(1 hunks)packages/types/CHANGELOG.md
(1 hunks)packages/types/package.json
(1 hunks)packages/vue/CHANGELOG.md
(1 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (3)
- .changeset/itchy-queens-cough.md
- .changeset/shaky-cities-search.md
- .changeset/fine-weeks-give.md
✅ Files skipped from review due to trivial changes (36)
- packages/astro/package.json
- packages/shared/package.json
- packages/themes/package.json
- packages/types/package.json
- packages/types/CHANGELOG.md
- packages/fastify/package.json
- packages/tanstack-react-start/package.json
- packages/backend/package.json
- packages/clerk-js/package.json
- packages/localizations/package.json
- packages/testing/package.json
- packages/react-router/package.json
- packages/elements/package.json
- packages/agent-toolkit/package.json
- packages/agent-toolkit/CHANGELOG.md
- packages/nuxt/package.json
- packages/elements/CHANGELOG.md
- packages/vue/package.json
- packages/remix/package.json
- packages/fastify/CHANGELOG.md
- packages/tanstack-react-start/CHANGELOG.md
- packages/astro/CHANGELOG.md
- packages/themes/CHANGELOG.md
- packages/remix/CHANGELOG.md
- packages/chrome-extension/CHANGELOG.md
- packages/shared/CHANGELOG.md
- packages/chrome-extension/package.json
- packages/nuxt/CHANGELOG.md
- packages/localizations/CHANGELOG.md
- packages/expo/package.json
- packages/express/package.json
- packages/clerk-js/CHANGELOG.md
- packages/react/package.json
- packages/vue/CHANGELOG.md
- packages/testing/CHANGELOG.md
- packages/backend/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/nextjs/package.json
- packages/nextjs/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/expo-passkeys/package.json
packages/react-router/CHANGELOG.md
packages/express/CHANGELOG.md
packages/expo/CHANGELOG.md
packages/react/CHANGELOG.md
packages/expo-passkeys/CHANGELOG.md
packages/*/package.json
📄 CodeRabbit Inference Engine (.cursor/rules/global.mdc)
All publishable packages should be placed under the packages/ directory
packages/*/package.json
: All publishable packages must be located in the 'packages/' directory.
All packages must be published under the @clerk namespace on npm.
Semantic versioning must be used across all packages.
Files:
packages/expo-passkeys/package.json
**/*
⚙️ CodeRabbit Configuration File
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
packages/expo-passkeys/package.json
packages/react-router/CHANGELOG.md
packages/express/CHANGELOG.md
packages/expo/CHANGELOG.md
packages/react/CHANGELOG.md
packages/expo-passkeys/CHANGELOG.md
packages/**/CHANGELOG.md
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Maintain detailed changelogs
Files:
packages/react-router/CHANGELOG.md
packages/express/CHANGELOG.md
packages/expo/CHANGELOG.md
packages/react/CHANGELOG.md
packages/expo-passkeys/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (9)
packages/expo-passkeys/package.json (2)
3-3
: Patch version bump looks correct and aligned with changesets
- Package remains under @clerk scope and inside packages/, satisfying publishing rules.
- Semantic versioning respected (patch bump).
- Matches the new CHANGELOG entry (0.3.32).
3-3
: Versions Verified and Aligned
- packages/expo-passkeys/package.json is at 0.3.32, matching the CHANGELOG header.
- @clerk/shared is at 3.21.1 and @clerk/types is at 4.78.1 in both their package.json files and the expo-passkeys CHANGELOG.
All checks pass—no further changes needed.
packages/expo-passkeys/CHANGELOG.md (1)
3-10
: Changelog entry is consistent with the patch release and dependency bumps
- Version header 0.3.32 present.
- Clearly lists updated dependencies @clerk/[email protected] and @clerk/[email protected] with commit reference.
- No functional changes implied for this package, which aligns with a patch bump.
packages/expo/CHANGELOG.md (1)
3-12
: Verified: workspace protocol dependencies in packages/expo
packages/expo/package.json
uses the Yarn workspace protocol ("workspace:^"
) for all @clerk packages, so fixed versions aren’t listed there. The changelog’s explicit version numbers (5.85.1, 3.21.1, 4.78.1, 5.42.2) accurately reflect the workspace package releases.No further changes required.
packages/react/CHANGELOG.md (1)
3-10
: Changelog entry LGTM: correct patch bump and dependency notes
- Version header and patch changes correctly reflect the new 5.42.2 release.
- Commit reference and listed dependency versions (3.21.1 and 4.78.1) match the published packages.
- Internal package.json files use
workspace:^
specifiers by design; the explicit versions in the changelog refer to the resolved workspace versions at release time.No changes required.
packages/express/CHANGELOG.md (1)
3-11
: ✅ Changelog entry and workspace dependency specs are correct
The monorepo uses theworkspace:^
protocol inpackages/express/package.json
to reference the newly bumped versions (@clerk/[email protected], @clerk/[email protected], @clerk/[email protected]), which will resolve at install time. No changes required.packages/react-router/CHANGELOG.md (3)
3-11
: Changelog entry looks good and consistent with previous releasesVersion header, section headings, nested dependency list, and commit reference are all formatted consistently with the rest of the file. No API or behavior claims are made beyond dependency bumps, which aligns with the PR intent.
3-11
: CI/tests reminderNo code changes here, so no additional tests are strictly necessary. Ensure existing integration/e2e suites cover basic flows with the updated shared/types/backend/clerk-react versions.
7-11
: Dependencies correctly use the workspace protocol
packages/react-router/package.json
intentionally declares its internal dependencies usingworkspace:^
, which means Yarn will automatically resolve to the versions declared in each package’s ownpackage.json
. You do not need to hard-code the baseline versions here.Please verify that the following workspace packages have been bumped to match the CHANGELOG (no edits needed in
react-router
):
- packages/*/package.json where
"name": "@clerk/shared"
→ ensureversion: "3.21.1"
- packages/*/package.json where
"name": "@clerk/types"
→ ensureversion: "4.78.1"
- packages/*/package.json where
"name": "@clerk/clerk-react"
→ ensureversion: "5.42.2"
- packages/*/package.json where
"name": "@clerk/backend"
→ ensureversion: "2.9.2"
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
Add error handling for
setActive
with stale organization data (#6550) by @LauraBeatrisUpdated dependencies [
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
Add error handling for
setActive
with stale organization data (#6550) by @LauraBeatrisUpdated dependencies [
413468c
]:@clerk/[email protected]
Patch Changes
Fix keyless drift logic to support client components and ensure only apps on development are included. Change createClerkClient to accept an argument for samplingRate in telemetry options and update the ClerkOptions type. (#6539) by @heatlikeheatwave
Import fs methods with nodeFsOrThrow rather than direct import. (#6555) by @heatlikeheatwave
Updated dependencies [
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
Add error handling for
setActive
with stale organization data (#6550) by @LauraBeatrisUpdated dependencies [
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
413468c
]:@clerk/[email protected]
Patch Changes
setActive
with stale organization data (#6550) by @LauraBeatris@clerk/[email protected]
Patch Changes
413468c
]:Summary by CodeRabbit
New Features
Bug Fixes
Chores